fix-llm-artifacts

# Fix LLM Artifacts Apply fixes from a previous `review-llm-artifacts` run with automatic safe/risky classification. ## Usage ``` /beagle-core:fix-llm-artifacts [--dry-run] [--all] [--category <name>] ``` **Flags:** - `--dry-run` - Show what would be fixed without changing files - `--all` - Fix entire codebase (runs review with --all first) - `--category <name>` - Only fix specific category: `tests|dead-code|abstraction|style` ## Instructions ### 1. Parse Arguments Extract flags from `$ARGUMENTS`: - `--dry-run` - Preview mode only - `--all` - Full codebase scan - `--category <name>` - Filter to specific category ### 2. Pre-flight Safety Checks ```bash # Check for uncommitted changes git status --porcelain ``` If working directory is dirty, warn: ``` Warning: You have uncommitted changes. Creating a git stash before proceeding. Run `git stash pop` to restore if needed. ``` Create stash if dirty: ```bash git stash push -m "beagle-core: pre-fix-llm-artifacts backup" ``` ### 3. Load Review Results Check for existing review file: ```bash cat .beagle/llm-artifacts-review.json 2>/dev/null ``` **If file missing:** - If `--all` flag: Run `review-llm-artifacts --all --json` first - Otherwise: Fail with: "No review results found. Run `/beagle-core:review-llm-artifacts` first." **If file exists, validate freshness:** ```bash # Get stored git HEAD from JSON stored_head=$(jq -r '.git_head' .beagle/llm-artifacts-review.json) current_head=$(git rev-parse HEAD) if [ "$stored_head" != "$current_head" ]; then echo "Warning: Review was run at commit $stored_head, but HEAD is now $current_head" fi ``` If stale, prompt: "Review results are stale. Re-run review? (y/n)" ### 4. Partition Findings by Safety Parse findings from JSON and classify by `fix_safety` field: **Safe Fixes** (auto-apply): - `unused_import` - Unused imports - `todo_comment` - Stale TODO/FIXME comments - `dead_code_obvious` - Obviously unreachable code - `verbose_comment` - Overly verbose LLM-style comments - `redundant_type` - Redundant type annotations **Risky Fixes** (require confirmation): - `test_refactor` - Test structure changes - `abstraction_change` - Class/function extraction - `code_removal` - Removing functional code - `mock_boundary` - Test mock scope changes - `logic_change` - Any behavioral modifications ### 5. Apply Safe Fixes If `--dry-run`: ```markdown ## Safe Fixes (would apply automatically) | File | Line | Type | Description | |------|------|------|-------------| | src/api.py | 15 | unused_import | Remove `from typing import List` | | src/models.py | 42 | verbose_comment | Remove 23-line docstring | ... ``` Otherwise, spawn parallel agents per category with `Task` tool: ``` Task: Apply safe fixes for category "{category}" Files: [list of files with findings in this category] Instructions: Apply each fix, preserving surrounding code. Report success/failure per fix. ``` Categories to parallelize: - `style` - Comments, formatting - `dead-code` - Imports, unreachable code - `tests` - Test-related safe fixes - `abstraction` - Safe refactors ### 6. Handle Risky Fixes For each risky fix, prompt interactively: ``` [src/services/auth.py:156] Remove seemingly unused authenticate_legacy() method? This method has no callers in the codebase but may be used externally. (y)es / (n)o / (s)kip all risky: ``` Track user choices: - `y` - Apply this fix - `n` - Skip this fix - `s` - Skip all remaining risky fixes ### 7. Post-Fix Verification Detect project type and run appropriate linters: **Python:** ```bash # Check if ruff config exists if [ -f "pyproject.toml" ] || [ -f "ruff.toml" ]; then ruff check --fix . ruff format . fi # Check if mypy config exists if [ -f "pyproject.toml" ] || [ -f "mypy.ini" ]; then mypy . fi ``` **TypeScript/JavaScript:** ```bash # Check for eslint if [ -f "eslint.config.js" ] || [ -f ".eslintrc.json" ]; then npx eslint --fix . fi # Check for TypeScript if [ -f "tsconfig.json" ]; then npx tsc --noEmit fi ``` **Go:** ```bash if [ -f "go.mod" ]; then go vet ./... go build ./... fi ``` ### 8. Run Tests ```bash # Python if [ -f "pyproject.toml" ] || [ -f "pytest.ini" ]; then pytest fi # JavaScript/TypeScript if [ -f "package.json" ]; then npm test 2>/dev/null || yarn test 2>/dev/null || true fi # Go if [ -f "go.mod" ]; then go test ./... fi ``` ### 9. Report Results ```markdown ## Fix Summary ### Applied Fixes - [x] src/api.py:15 - Removed unused import `List` - [x] src/models.py:42-64 - Removed verbose docstring - [x] src/auth.py:156-189 - Removed dead method (user confirmed) ### Skipped Fixes - [ ] src/services/cache.py:23 - User declined risky fix - [ ] tests/test_api.py:45 - Test refactor skipped ### Verification Results - Linter: PASSED - Type check: PASSED - Tests: PASSED (42 passed, 0 failed) ### Diff Summary ```bash git diff --stat ``` ## Cleanup On successful completion (all verifications pass): ```bash rm .beagle/llm-artifacts-review.json ``` If any verification fails, keep the file and report: ``` Review file preserved at .beagle/llm-artifacts-review.json Fix issues and re-run, or restore with: git stash pop ``` ## Example ```bash # Preview all fixes without applying /beagle-core:fix-llm-artifacts --dry-run # Fix only dead code issues /beagle-core:fix-llm-artifacts --category dead-code # Full codebase scan and fix /beagle-core:fix-llm-artifacts --all # Fix style issues only, preview first /beagle-core:fix-llm-artifacts --category style --dry-run ```